Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Keyboard property in WinUI Entry #1554

Merged
merged 7 commits into from
Sep 23, 2021
Merged

Implement Keyboard property in WinUI Entry #1554

merged 7 commits into from
Sep 23, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Implement Keyboard property in WinUI Entry.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • No

@Redth Redth force-pushed the winui-entry-keyboard branch from 47f3002 to 661aca7 Compare July 12, 2021 15:56
@rachelkang rachelkang self-requested a review July 12, 2021 21:28
rachelkang
rachelkang previously requested changes Jul 13, 2021
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz The keyboard type doesn't change :/

and build is failing :(

@Redth Redth force-pushed the winui-entry-keyboard branch 2 times, most recently from b141ed7 to 14dc27a Compare July 14, 2021 19:33
@rachelkang
Copy link
Member

@jsuarezruiz The keyboard type doesn't change :/

and build is failing :(

hmm I tested again, but it's the same :/

@Redth Redth force-pushed the winui-entry-keyboard branch from 14dc27a to 5662606 Compare July 15, 2021 18:08
@rachelkang
Copy link
Member

still not working :(

rmarinho and others added 3 commits September 2, 2021 17:03
@rmarinho
Merge branch 'main' into winui-entry-keyboard
457467b
@rmarinho
Merge branch 'main' into winui-entry-keyboard
123abea
@Redth
Consolidate all InputScope update logic
82e61dc 
There was still an extension method which was updating the InputScope property independently of any others, so we had a last setter win situation.

This change ensures the UpdateInputScope is called whenever anything needs to ultimately set that property and accounts for multiple things which influence the set of input scope names that calculate the final value.
@Redth Redth requested a review from rachelkang September 22, 2021 13:07
rachelkang
rachelkang approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works great! Seeing the numeric keyboard on winui entry

@rmarinho rmarinho merged commit 1f59688 into main Sep 23, 2021
@rmarinho rmarinho deleted the winui-entry-keyboard branch September 23, 2021 14:07
@Redth Redth added this to the 6.0.101-preview.9 milestone Sep 27, 2021
@Redth Redth mentioned this pull request Nov 2, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@samhouts samhouts added the fixed-in-6.0.101-preview.10 Look for this fix in 6.0.101-preview.10! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachelkang rachelkang rachelkang approved these changes

Assignees
No one assigned
Labels
fixed-in-6.0.101-preview.10 Look for this fix in 6.0.101-preview.10! platform/windows 🪟
Projects
None yet
Milestone
6.0.101-preview.9
Development

Successfully merging this pull request may close these issues.
5 participants
@jsuarezruiz @rachelkang @Redth @rmarinho @samhouts